On 7/22/15 10:54 PM, Eryu Guan wrote: > On Wed, Jul 22, 2015 at 10:22:56AM -0500, Eric Sandeen wrote: >> On 7/22/15 3:22 AM, Eryu Guan wrote: >>> This basically does the same as in commit >>> >>> 90a3bfc xfs: be compatible with older mkfs.xfs which has no v5 support >>> >>> which left xfs/078 behind. >>> >>> Signed-off-by: Eryu Guan <eguan@xxxxxxxxxx> >> >> This is fine as far as it goes, but I think xfs/045 needs it too: >> >> >> if ! _scratch_mkfs_xfs -m crc=0 >$tmp.out 2>&1 >> then >> cat $tmp.out >> echo "!!! failed to mkfs on $SCRATCH_DEV" >> exit >> fi >> >> It fails "gracefully" but it doesn't need to, in this case. > > xfs/045 passed on my RHEL6 test box, I think that's because xfs/045 (and > some other tests) takes use of _scratch_mkfs_xfs not call $MKFS_XFS_PROG > directly, so commit 90a3bfc takes care of all the dirty work. > > Thanks for the review! Oh, you are right ... how did I miss that it's calling _scratch_mkfs_xfs, I'm sorry! Yes, your patch is fine, and complete. Oops! :) Thanks, -Eric -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
