Re: [PATCH V2] generic: add fiemap test that does prealloc

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Wed, Jun 17, 2015 at 01:32:29PM -0700, Josef Bacik wrote:
> I noticed that btrfs wasn't setting unwritten on prealloc test, and then
> subsequently noticed that we weren't testing fiemap on prealloc extents with the
> fiemap-tester.  This patch adds another test that does the same as generic/225
> only with prealloc enabled.  Thanks,
> 
> Signed-off-by: Josef Bacik <jbacik@xxxxxx>
....
> +_require_xfs_io_command "fiemap"
> +_require_xfs_io_command "falloc"
> +
> +_scratch_mkfs > /dev/null 2>&1
> +_scratch_mount > /dev/null 2>&1
> +
> +rm -f $seqres.full
> +fiemapfile=$SCRATCH_MNT/$seq.fiemap
> +
> +[ -x $here/src/fiemap-tester ] || _notrun "fiemap-tester not built"
> +
> +seed=`date +%s`
> +
> +echo "using seed $seed" >> $seqres.full
> +
> +echo "fiemap run with sync"
> +$here/src/fiemap-tester -q -S -s $seed -r 200 $fiemapfile 2>&1 | \
> +	tee -a $seqres.full
> +
> +if [ $? -ne 0 ]; then
> +	if grep -q "Operation not supported" $seqres.full; then
> +	      _notrun "FIEMAP not supported by this filesystem type: $FSTYP"
> +	fi
> +	status=$?
> +	exit
> +fi

No need for the FIEMAP not supported check - that is done by the
'+_require_xfs_io_command "fiemap"' line above and so any failure
of fiemap-tester is something that should fail the test.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux