On Tue, May 19, 2015 at 01:13:42PM -0400, Josef Bacik wrote: > I noticed that btrfs wasn't setting unwritten on prealloc test, and then > subsequently noticed that we weren't testing fiemap on prealloc extents with the > fiemap-tester. This patch adds another test that does the same as generic/225 > only with prealloc enabled. Thanks, Fails on XFS, but that's because XFS is doing things fiemap-tester does not understand (speculative prealloc beyond EOF when appending writes occur on files larger than 64k) and hence XFS ends up with zeroed data on disk in places where fiemaptester is expecting preallocated blocks. i.e. there's not data corruption, and nothing wrong with XFS's behaioviour, just a broken assumption that the filesystem will lay out data due to buffered writes and delayed allocation exactly as it expects. IOWs, i think that fiemap-tester might need to direct IO to get the results it expects, not buffered IO... > +_scratch_mount > /dev/null 2>&1 > + > +rm -f $seqres.full > +fiemapfile=$SCRATCH_MNT/$seq.fiemap > +fiemaplog=$SCRATCH_MNT/$seq.log The log file to use for debug information is $seqres.full. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
