On 5/14/15 12:44 AM, Eryu Guan wrote: > On Thu, May 14, 2015 at 12:23:14AM -0500, Eric Sandeen wrote: >> All good advice; sigh, I am rusty! Thanks, will resend with fixes. >> >> (Started as using test dev so left some things out; not sure I need a trap if there is nothing to clean up? Also do we need to require attr on xfs? Can't remember if we can compile that out, but I guess it's harmless to include it) > > I did a "grep _require_attrs tests/xfs/*" and result showed several > tests in xfs require attrs. At least it checks if ATTR_PROG exists :) Yes, I forgot about that ;( > And I think we need a trap and cleanup even if there's no obvious things > to clean, some functions use $tmp.xxx internally, a cleanup could remove > all these tmp files too, and trap plays with exit status, so it's still > needed. Fair enough, thanks for the review. -Eric -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
