Re: [PATCH 2/3] xfstests: btrfs: test device replace, with EIO on the src dev

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Tue, May 05, 2015 at 11:13:44PM +0800, Anand Jain wrote:
> 
> Dave,
> 
>  Thanks for comments. I am rewriting it.
> 
>  But any idea why should _scratch_mkfs_dmerror (below) should
>  fail with one of the device in SCRATCH_DEV_POOL being busy.?
>  (when I start the script non of the device provided is actually
>  busy).

$SCRATCH_DEV is the first device in $SCRATCH_DEV_POOL, right?

> +SCRATCH_DEV_POOL_DEV1="`echo $SCRATCH_DEV_POOL | $AWK_PROG '{print $1}'`"
> +SCRATCH_DEV_POOL_DEV2="`echo $SCRATCH_DEV_POOL | $AWK_PROG '{print $2}'`"

BTW, don't shout so much in your code: dev1 and dev2 are perfectly
good local variable names. In general, local variables are in lower
case, global/exported variables are in upper case.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux