Re: [PATCH 3/4] xfs/045: can't change UUID on v5 filesystems.

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On 5/4/15 7:51 PM, Dave Chinner wrote:
> On Mon, May 04, 2015 at 05:48:31PM -0500, Eric Sandeen wrote:
>> On 5/4/15 5:01 PM, Dave Chinner wrote:
>>> From: Dave Chinner <dchinner@xxxxxxxxxx>
>>>
>>> So pass "-m crc=0" to the scratch_mkfs command so that we only run
>>> on old v4 format filesystems where the UUID can be changed.
>>>
>>> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
>>
>> hm, given that I might "fix" this should we instead trap
>> on an xfs_db uuid failure, and _notrun the test?
>> (oh, but older xfs_db let it go, didn't it.  sigh).
>>
>> I guess nothing about the presence of crc vs. non-crc
>> matters for this test, so turning it off by default is probably ok.
>> It could use a comment about why it's got "-m crc=0" though, at
>> least.
> 
> Added. New patch below.
> 

Thanks.

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux