On Thu, Apr 02, 2015 at 12:10:41PM +0800, Eryu Guan wrote: > On Thu, Apr 02, 2015 at 09:29:54AM +1100, Dave Chinner wrote: > > On Wed, Apr 01, 2015 at 01:57:10PM -0400, Brian Foster wrote: > > > On Wed, Apr 01, 2015 at 09:54:15PM +0800, Eryu Guan wrote: > > > > xfs used to panic in this test, this xfs commit fix the bug > > > > > > > > 8d6c121 xfs: fix buffer use after free on IO error > > > > > > > > ext4 and btrfs trigger WARNING on current 4.0-rc3 kernel > > > > > > > > Signed-off-by: Eryu Guan <eguan@xxxxxxxxxx> > > > > --- > > > > v2: > > > > - add _require_dm_snapshot() function to require dm snapshot target > > > > - make sure SCRATCH_DEV has enough space for the test > > > > - fail the test directly when failures detected in setup phase > > > > > > > > > > FYI, the mail subject header hasn't changed so Dave might not notice > > > this is a new patch. > > > > Saw it. > > > > > > +_mount /dev/mapper/$vgname-$snapname $mnt > > > > + > > > > +# write 5M data to the snapshot > > > > +$XFS_IO_PROG -fc "pwrite 0 5m" $mnt/testfile >>$seqres.full 2>&1 > > > > + > > > > > > I noticed there were no errors in $seqres.full when running this test. > > > E.g., the pwrite succeeds because nothing is written back to disk at > > > that point. The fs does shutdown due to the flush on umount, but it's > > > kind of hidden away up in the _cleanup() function. > > > > > > Kind of a nit, but we could be a bit more explicit and do a '-c fsync' > > > after the pwrite here? That way it's clear that writeback to disk is > > > part of the core test and we have a little feedback in $seqres.full that > > > I/O errors occurred, as expected. > > > > Added the -c fsync as I pulled it in. > > I was thinking about adding fsync or sync at first, but it causes > problems in cleanup. For some reason(I don't know clearly) fsync > sometimes pins the snapshot in use and vgremove can't remove all lvs, so > SCRATCH_DEV is still used by the test vg when running next test > > our local _scratch_mkfs routine ... > mkfs.xfs: cannot open /dev/sda6: Device or resource busy > check: failed to mkfs $SCRATCH_DEV using specified options > > From 081.full I can see > > Logical volume vg_081/snap_081 contains a filesystem in use. > > The test vg/lv has to be removed manually after the test > > vgremove -f vg_081 > > I don't find a proper way to fix it yet, but simply adding 'sleep 1' > before vgremove in _cleanup works for me > Hmm, I haven't seen that one. Seems fine for me as a temporary workaround though. Perhaps include it with the udev-settle thing that Dave needs on the creation side of things..? Brian > [root@hp-dl388eg8-01 xfstests]# git diff > diff --git a/tests/generic/081 b/tests/generic/081 > index 3e17d34..29b0240 100755 > --- a/tests/generic/081 > +++ b/tests/generic/081 > @@ -36,6 +36,7 @@ _cleanup() > rm -f $tmp.* > # lvm may have umounted it on I/O error, but in case it does not > $UMOUNT_PROG $mnt >/dev/null 2>&1 > + sleep 1 > $LVM_PROG vgremove -f $vgname >>$seqres.full 2>&1 > $LVM_PROG pvremove -f $SCRATCH_DEV >>$seqres.full 2>&1 > } > > Thanks, > Eryu -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
