On Wed, 1 Apr 2015, Jan Tulak wrote: > > > --- a/common/rc > > > +++ b/common/rc > > > @@ -21,6 +21,7 @@ > > > #----------------------------------------------------------------------- > > > > > > BC=$(which bc 2> /dev/null) || BC= > > > +SUPPORTED_TESTS="[a-zA-Z0-9-]\+" > > > > but $SUPPORTED_TESTS doesn't define the correct format for the test > > names. It defines valid characters, but does not enforce the fact > > that the first 3 characters must match [0-9] (i.e. the NNN bit), and > > then the rest is optional but must be alphanumeric symbols and dash. > > i.e it should be matching against: > > > > I did it to be "generous on input, strict on output" - the ./new script always put 3 numbers at the beginning, but if someone for some reason needs to avoid it, it will still work. Enforcing it is easy, but is it needed? Hi Jan, I thought that we've already established that indeed yes, it is needed. Having ./new script to create the right format is nice, but it's not enough. You can easily create new tests without ./new script and while I do not know how many people are using it, I've never used it myself. Please enforce the naming format. Thanks! -Lukas -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
