[PATCH] fix "utility required warning" with empty utility name

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



From: Zhao Lei <zhaolei@xxxxxxxxxxxxxx>

In generic/019, if we hadn't install fio, we will get following output:
 FSTYP         -- btrfs
 PLATFORM      -- Linux/x86_64 lenovo 4.0.0-rc3_HEAD_9eccca0843205f87c00404b663188b88eb248051_
 MKFS_OPTIONS  -- /dev/sda6
 MOUNT_OPTIONS -- -o context=system_u:object_r:nfs_t:s0 /dev/sda6 /var/ltf/tester/scratch_mnt

 generic/019      [not run]  utility required, skipped this test <- *
 Not run: generic/019
 Passed all 0 tests

Reason of blank utility name is:
$1 and $2 are reversed in _require_command(), this patch fixed
this error.

Signed-off-by: Zhao Lei <zhaolei@xxxxxxxxxxxxxx>
---
 common/rc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/rc b/common/rc
index 1ed9df5..febad8c 100644
--- a/common/rc
+++ b/common/rc
@@ -1276,7 +1276,7 @@ _require_realtime()
 #
 _require_command()
 {
-    [ -n "$1" ] && _cmd="$1" || _cmd="$2"
+    [ -n "$2" ] && _cmd="$2" || _cmd="$1"
     [ -n "$1" -a -x "$1" ] || _notrun "$_cmd utility required, skipped this test"
 }
 
-- 
1.8.5.1

--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux