Re: [PATCH 3/4] common: append -d option to XFS_COPY_PROG when testing v5 xfs

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On 3/11/15 10:48 AM, Eric Sandeen wrote:
> On 3/11/15 7:15 AM, Eryu Guan wrote:
>> xfs_copy doesn't work on v5 xfs without -d option, this fails xfs/073
>> when testing xfs with MKFS_OPTIONS="-m crc=1" set.
> 
> Neat, I did not know about the "=~" trick ;)
> 
> Test xfs/073 adds -d already, but two -d's are accepted...
> 
> ... but the xfs/073 fails due to the fallback to nouuid, forced by
> the duplicate ID which is found:
> 
> @@ -17,6 +17,7 @@
>  All copies completed.
>  checking new image
>  mounting new image on loopback
> +retrying mount with nouuid option

Oh, patch 4 fixes this.

Dave, you might want to apply 3 & 4 in swapped order.

I think this is ok for now,

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux