> > Simply said > > > > _is_block_dev "$TEST_DEV" > > > > will return empty string if $TEST_DEV either does not exist or $TEST_DEV itself > > is empty string. However if someone calls > > > > _is_block_dev > > > > he'll get an error so he knows that he needs to fix his code. > > > > These 2 way have the respective advantages. > For me, both way is acceptable as long as it can fix titled bug. > > I'll send v4 based on your suggestion, to provide Dave Chinner a selection. Ok thanks, I think that simply using quotes is better then rewriting the thing and introducing new helpers. But in the end its Dave's decision to make. Thanks! -Lukas -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html