On Wed, Feb 18, 2015 at 10:21:16AM +0000, Andrew Price wrote:
> On 18/02/15 01:21, Dave Chinner wrote:
> >On Mon, Feb 16, 2015 at 02:50:39PM +0800, Zhaolei wrote:
> >>From: Zhao Lei <zhaolei@xxxxxxxxxxxxxx>
> >>
> >>We need to check "$1" instead "$SCRATCH_DEV" in this function.
> >>And make tabs same with other code.
> >>
> >>Signed-off-by: Zhao Lei <zhaolei@xxxxxxxxxxxxxx>
> >>---
> >> common/rc | 14 +++++++-------
> >> 1 file changed, 7 insertions(+), 7 deletions(-)
> >>
> >>diff --git a/common/rc b/common/rc
> >>index 7449a1d..76522d4 100644
> >>--- a/common/rc
> >>+++ b/common/rc
> >>@@ -1284,13 +1284,13 @@ _require_command()
> >> # $1 - device
> >> _require_block_device()
> >> {
> >>- if [ -z "$1" ]; then
> >>- echo "Usage: _require_block_device <dev>" 1>&2
> >>- exit 1
> >>- fi
> >>- if [ "`_is_block_dev $SCRATCH_DEV`" == "" ]; then
> >>- _notrun "require $1 to be valid block disk"
> >>- fi
> >>+ if [ -z "$1" ]; then
> >>+ echo "Usage: _require_block_device <dev>" 1>&2
> >>+ exit 1
> >>+ fi
> >>+ if [ "`_is_block_dev $1`" == "" ]; then
> >>+ _notrun "require $1 to be valid block disk"
> >>+ fi
> >> }
> >
> >The change is fine - the reformating of the code is not. 8 space
> >tabs
>
> To be clear, do you mean 8 spaces or single tabs?
Single tab, but tabs are the width of 8 spaces. Same as you'd use
for writing new kernel code.
Cheers,
Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
