On Thu, Feb 12, 2015 at 08:48:14PM +0800, Zhaolei wrote: > From: Zhao Lei <zhaolei@xxxxxxxxxxxxxx> > > _is_block_dev() will show above warning when "$dev" is not exist. > It happened when user hadn't set $SCRATCH_DEV(optional) and check > $TEST_DEV. _is_block_dev() is used in many places to check whether the block device exists. i.e. I'd suggest that _is_block_dev() should return an empty string to indicate it's not a block device rather than exit if a null. That means we don't have to execute _is_block_dev() in a subshell (i.e. via `_is_block_dev ...`) to prevent it from killing the script that runs it if the block device passed to it is null. That means we don't have to add checks everywhere it is called, and we can simplify the calling convention at the same time.... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
