On Thu, Feb 05, 2015 at 10:37:12PM -0800, Jaegeuk Kim wrote: > This patch add _get_quota_option to assign the mount option selectively > in: > > tests/xfs/087 > > Signed-off-by: Jaegeuk Kim <jaegeuk@xxxxxxxxxx> > --- > common/quota | 15 +++++++++++++++ > tests/xfs/087 | 7 ++++--- > 2 files changed, 19 insertions(+), 3 deletions(-) > > diff --git a/common/quota b/common/quota > index b320cf2..a103826 100644 > --- a/common/quota > +++ b/common/quota > @@ -78,6 +78,21 @@ _require_xfs_quota() > } > > # > +# give quota option accoring to the filesystems. > +# > +_get_quota_option() > +{ > + case $FSTYP in > + xfs) > + _require_xfs_quota > + echo "-o uquota" > + ;; > + *) > + ;; > + esac > +} Looking at this, it's pretty specific to the test, so it's probably best just to leave it as a helper function in the test itself. Otherwise look s good. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html