Re: [PATCH v5] btrfs: add regression test for remount with thread_pool resized

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Mon, Jan 26, 2015 at 05:31:43PM +0800, Qu Wenruo wrote:
> >+# get standard environment, filters and checks
> >+. ./common/rc
> >+. ./common/filter
> >+
> >+# real QA test starts here
> >+_supported_fs btrfs
> >+_supported_os Linux
> >+_require_scratch
> >+
> >+_scratch_mkfs > /dev/null 2>&1 || _fail "mkfs failed"
> IMHO, it's better to add a new btrfs_mkfs_filter(or something
> similar) to common/filter.btrfs,
> and modify the btrfs case in common/rc:scratch_mkfs() to use the
> filter to wipe the "Performing TRIM"
> line *ONLY*, as other btrfs filters do.

There's already common/filter:_filter_mkfs which has a $FSTYP switch
in it. That's the place to add any btrfs specific mkfs filters,
either in line or as a callout to a special functionin common/btrfs.

Cheers.

Dave.

-- 
Dave Chinner
david@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux