Commit 01d42b7efe3fcb9169befda3072c41d25a87c920 broke the check for the success status of running fstrim. The [ ] bracets should have been killed. This made several tests being skipped even when the test/scratch devices support trim/discard. For reference: $ [ fstrim /mnt/ ] || echo foobar bash: [: fstrim: unary operator expected foobar $ fstrim /mnt/ || echo foobar $ echo $? 0 Signed-off-by: Filipe Manana <fdmanana@xxxxxxxx> --- common/rc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/rc b/common/rc index 5ce3322..5770b0a 100644 --- a/common/rc +++ b/common/rc @@ -2388,7 +2388,7 @@ _require_batched_discard() exit 1 fi _require_fstrim - [$FSTRIM_PROG $1 > /dev/null 2>&1] || _notrun "FITRIM not supported on $1" + $FSTRIM_PROG $1 > /dev/null 2>&1 || _notrun "FITRIM not supported on $1" } _require_dumpe2fs() -- 2.1.3 -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
