On Mon, Dec 15, 2014 at 03:02:09PM -0500, Theodore Ts'o wrote: > On Tue, Dec 16, 2014 at 01:32:00AM +0800, Eryu Guan wrote: > > On Mon, Dec 15, 2014 at 10:47:23AM -0500, Theodore Ts'o wrote: > > > These tests use the falloc command in xfs_io, and there are some file > > > systems (ext3) or file system configurations (ext4 in ext3 > > > compatibility mode) which do not support fallocate. So add the > > > explicit requirement to avoid false test failures. > > > > The two tests fail because of no defrag support on ext3 on my test host. > > > > ext4/308 [not run] defragmentation not supported for fstype "ext3" > > generic/324 19s ... [not run] defragmentation not supported for fstype "ext3" > > The problem is if you are using ext4 in compatibility mode for ext3 > file system, it does support the defrag ioctl, but it can't support > fallocate for non-extent-mapped files (since we can't mark the blocks > as being uninitialized). (Well, we could support fallocate in > no-hide-stale mode, but that's only something that Google and Tao Bao > is using, and that patch isn't upstream anyway, since it's been > declared unclean. :-) > > > ext4/308 also uses fiemap command, I think we need another check here > > > > _require_xfs_io_command "fiemap" > > ext4 is always going to support the fiemap ioctl, so I think we're > good there. That makes sense, thanks for the explanation! The change looks good to me. Reviewed-by: Eryu Guan <eguan@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
