Re: [patch, v3] add an aio test which closes the fd before destroying the ioctx

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



Zach Brown <zab@xxxxxxxxx> writes:

> On Tue, Aug 26, 2014 at 12:05:11PM -0400, Jeff Moyer wrote:
>> Benjamin LaHaise <bcrl@xxxxxxxxx> writes:
>> 
>> > Does someone already have a simple test case we can add to the libaio test 
>> > suite to verify this behaviour?
>> 
>> I can't reproduce this problem using a loop device, which is what the
>> libaio test suite uses.  Even when using real hardware, you have to have
>> disks that are slow enough in order for this to trigger reliably (or
>> at all).
>
> I wonder if you could use something like dm suspend to abuse indefinite
> latencies.

Or perhaps dm-delay.

>> I could write a more targeted test within xfstests, but I don't think
>> that's strictly necessary (it would just make it more clear what the
>> expectations are, and maybe bump the hit rate percentage up).
>
> I think it'd be worth it (he says, not commiting *his* time).  It would
> have been nice if a targeted test helped Dave raise the alarm
> immediately rather than gnaw away at his brain with inconsistent mostly
> unrelated failures for months.

Sure.

-Jeff
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux