On Fri, 22 Aug 2014 11:09:15 -0400, "Theodore Ts'o" <tytso@xxxxxxx> wrote: > The mke2fs command will allow a subsequent -b option to override a > pervious one. So something like this will work: > > mke2fs -t ext4 -b 4096 -b 2048 -b 1024 /tmp/foo.img 100 No, This will not works. Looks like you have missed the point. helper has following signature: _scratch_mkfs_sized <size in bytes> [optional blocksize] But mke2fs accept filesystem size accounted in fs-blocks, so in order to convert size in blocks to number of blocks we have to figure out blocksize. In fact currently _ALL_ users of _scratch_mkfs_sized skip this optional parameter, so it is reasonable to use the one from MKFS_OPTIONS instead other which is hard coded inside helper. And as you can see from my patch logic is follows: 1) Use explicit block size if it was passed as function parameter 2) if not (1) then Use block size defined from MKFS_OPTION 3) if not (2) Use default block size (4096) > > So you don't really need to do hacks with sed. Also, if MKFS_OPTIONS > has a -b option, then you shouldn't need to do any -b overrides at > all, since that probably means the person doing the xfstest run > actually specified a block size directly for a Good Reason. We might > want to issue a warning message if the block size specified by > MKFS_OPTIONS doesn't match what the test file system uses, but that's > more of a sanity check than anything else. > > Also, see my comments about dbsize; it might be a good idea if we want > to do this sort of thing to refactor out a standard way of determining > the block size of the test file system. > > Cheers, > > - Ted -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
