Re: [PATCH 2/6] common: _scratch_mkfs_sized should inherent default block size from test_dev

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]



On Thu, Aug 21, 2014 at 10:01:06AM -0400, Theodore Ts'o wrote:
> On that note, what is dbsize supposed to be?  It appears to be set in
> _filter_mkfs?  It appears from context that this is supposed to be the
> data block size?  Currently this gets hard coded to 4k for non-xfs
> file systems, and it assumes a 256 byte inode.
> 
> It looks like we should be extracting this information from dumpe2fs
> for extN file systems?

*nod*

Most of the special mkfs sauce that is used by XFS specific tests
simply has not been written for other filesystems.  The hard coded
results from _filter_mkfs are just there so that generic tests that
use dbsize/isize mostly work.

So if want you to add this "reflect reality" functionality for ext4
you are more than welcome to do it. :)

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystems Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux