On 06/19/2014 02:56 PM, Dave Chinner wrote:
On Thu, Jun 19, 2014 at 01:50:04PM +0800, Xing Gu wrote:
This is a test to verify the procedure which checks whether
offset + len is bigger than i_size is removed from do_fallocate
in collapse range to the file system, and ensure that i_size is
not going to change.
Signed-off-by: Xing Gu <gux.fnst@xxxxxxxxxxxxxx>
Does the test really need 3 minutes?
Actually, this case can easily reproduce the issue below 30s.
We can't keep adding tests that take minutes to *maybe* hit a
regression. This isn't even testing a regression - the
COLLAPSE_RANGE feature was introduced in 3.15-rc1 and this bug fixed
in 3.15-rc3, so there are no kernels out there that have this
bug in them.
IOWs, I really don't think we should be the runtime of a typical
test cycle by 5% to exercise this non-bug. Maybe 30s at most, but a
shorter, directly targeted test would be better.
And FWIW, there's nothing ext4 specific about this test - it should
be in the generic group if we are going to add it.
Indeed, it's not ext4 specific.
What about modifying this case according to Lukas's comment?
Thanks!
Regards,
Xing Gu
Cheers,
Dave.
--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
