On Fri, Jun 13, 2014 at 04:33:46PM -0500, Eric Sandeen wrote: > generic/317 and generic/318 fail un-gracefully on older kernels > which don't support userns; fix that by running a simple test > as a prerequisite and fail gracefully if needed. > > Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> > --- > > diff --git a/tests/generic/317 b/tests/generic/317 > index e016a42..8919db2 100755 > --- a/tests/generic/317 > +++ b/tests/generic/317 > @@ -56,6 +56,8 @@ _supported_os Linux > [ -x $nsexec ] || _notrun "$nsexec executable not found" > [ -x $lstat64 ] || _notrun "$lstat64 executable not found" > > +$nsexec -U true 2>/dev/null || _notrun "user namespaces not supported by this kernel" > + Can you turn this into a _requires_user_namespaces()? i.e. check for $nsexec and the kernel support in one function. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
