Hi, On Tue, 2019-07-02 at 18:12 +0900, Akira TAGOH wrote: > No. I thought we agreed with not using blackboxed parameters in > private discussions. that API potentially expects to override > everything with FcPattern which isn't desired at this point. if you > want to override a property other than FC_FONT_VARIATIONS, it should > be "const FcChar8 *object, const FcChar8 *value" instead of > "FcPattern *custom". Okay, I just think this is one possible API proposal candidate, just note it here. From current requirements, maybe only font variations and features are planed to be overridden. Here are another proposal for FcDirCacheAddStyle. FcDirCacheAddStyle (const FcConfig *config, const FcChar8 *file, const unsigned int index, const FcChar8 *stylename, const FcChar8 *variations, const FcChar8 *features); If we don't plan to override other property in custom font style, I think the above API is okay for me. Feel free to comment it. Thanks, Peng _______________________________________________ Fontconfig mailing list Fontconfig@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/fontconfig
