Re: [PATCH] Please make the output of cache files reproducible

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


not sure what it should be named but the curly brackets is supposed to
be started at a new line, need a space after a function name etc.

Aside from that:
+static int64_t
+FcDirChecksumNano (struct stat *statb) {
+    /* No nanosecond component to parse */
+    if (getenv("SOURCE_DATE_EPOCH"))
+       return 0;
+    return statb->st_mtim.tv_nsec;
+    return 0;

good to move the last "return 0" line into #else statement for
HAVE_STRUCT_STAT_ST_MTIM. also if the platforms doesn't support
st_mtim in stat structure, no need to check the env var even. it can
be entered into #ifdef too.


On Mon, May 14, 2018 at 7:55 PM, Chris Lamb <lamby@xxxxxxxxxx> wrote:
> Chris Lamb wrote:
>> > Please follow up on the coding styles and write a document for this behavior.
>> Thank you for your quick reply. Can you clarify on the coding style
>> angle? I tried to match what was already in the surrounding code.
> Gentle ping on this? :)
> Regards,
> --
>       ,''`.
>      : :'  :     Chris Lamb
>      `. `'`      lamby@xxxxxxxxxx /
>        `-

Fontconfig mailing list

[Index of Archives]     [Fedora Fonts]     [Fedora Users]     [Fedora Cloud]     [Kernel]     [Fedora Packaging]     [Fedora Desktop]     [PAM]     [Gimp Graphics Editor]     [Yosemite News]

  Powered by Linux