Re: Segfault within fc-list when not provided with a valid configuration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks. but how often does it happen? I think it's only when the memory allocation failed though.

On Thu, Mar 5, 2015 at 10:36 PM, Matt Breedlove <breedlove.matt@xxxxxxxxx> wrote:
Beginning with version 2.11.91 up to trunk:

In fcinit.c, the FcInitBringUptoDate function doesn't properly validate the return value for FcConfigGetCurrent() leading to a segfault when attempting to reference config->rescanInterval.

fc-list suffers from this problem and crashes as a result when not provided with a valid fontconfig file.  Versions prior to 2.11.91 don't exhibit the same behavior.

mingw-w64 / gcc 4.92 / Windows 8.1 x64


diff --git a/src/fcinit.c b/src/fcinit.c
index db62c21..1315a52 100644
--- a/src/fcinit.c
+++ b/src/fcinit.c
@@ -209,6 +209,9 @@ FcInitBringUptoDate (void)
     FcConfig   *config = FcConfigGetCurrent ();
     time_t     now;

+    if (!config)
+        return FcFalse;
+
     /*
      * rescanInterval == 0 disables automatic up to date
      */

Matt Breedlove

_______________________________________________
Fontconfig mailing list
Fontconfig@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/fontconfig




--
Akira TAGOH
_______________________________________________
Fontconfig mailing list
Fontconfig@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/fontconfig

[Index of Archives]     [Fedora Fonts]     [Fedora Users]     [Fedora Cloud]     [Kernel]     [Fedora Packaging]     [Fedora Desktop]     [PAM]     [Gimp Graphics Editor]     [Yosemite News]

  Powered by Linux