Hi,
Jon TURNEY wrote:
> On 27/06/2013 05:16, Akira TAGOH wrote:
>> [...]
>> New commits:
>> commit 38ab7ab2fbd83c0c62e4b78302b5fe89da0cb79e
>> Author: Akira TAGOH <akira@xxxxxxxxx>
>> Date: Thu Jun 27 13:10:27 2013 +0900
>> Fix a incompatible pointer warning on NetBSD
>>[...]
> This change makes it a configure error not to have scandir(). This
prevents
This also fails on Solaris, when compiling with Sun Studio. But it's
actually not scandir that's the problem. -Werror is not available as
compiler flag. Before, this only made the check for posix_fadvise fail,
which was no error (and I hadn't even noticed); but the scandir check,
which uses the same flag, now is.
Sun Studio has an equivalent flag ('-errwarn=%all'); but I'm not sure if
it's even necessary. Wouldn't it be sufficient to check *only* for the
NetBSD syntax of scandir specifically? The POSIX signature could be
assumed in all other cases without a further check, like before.
Now to posix_fadvise (not as important though:). I've checked in the
original bugreport (https://bugs.freedesktop.org/show_bug.cgi?id=52573),
but I'm not sure if I understand from it why -Werror is necessary
(http://cgit.freedesktop.org/fontconfig/commit/?id=8daa863c6d84ea56cc2f568a89316690e784a277).
Wouldn't AC_LINK_IFELSE fail at the linker stage even without -Werror if
there was a problem with the declaration of posix_fadvise? Or was there
some other problem?
Raimund
--
Worringer Str 31 Duesseldorf 40211 DE home: <rs@xxxxxxxx>
+49-179-2981632 icq 16845346 work: <rs@xxxxxxxxxxxxxxx>
_______________________________________________
Fontconfig mailing list
Fontconfig@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/fontconfig
