Re: FcConfigSubstituteWithPat enhancement?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I don't think many are using custom elements.  I only know Pango.  I think
it's safe to go ahead to push this out and deal with consequences.  I'll roll
a patch and push up.

On 13-01-10 10:54 PM, Akira TAGOH wrote:
> Right. I've fixed partly this issue for namelang related stuff in 2.10.2. that
> would makes sense if user-defined values is copied from the pattern to the
> result. that said we may need to test it carefully if it has any side-effects
> in apps.
> 
> 
> On Fri, Jan 11, 2013 at 7:36 AM, Behdad Esfahbod <behdad@xxxxxxxxxx
> <mailto:behdad@xxxxxxxxxx>> wrote:
> 
>     The SubstituteWithPat function copies the "best match" element value from the
>     pattern to the font pattern for any element not in the font pattern.  However,
>     for custom elements that ends up just copying the first value.  Which
>     typically is NOT what you want.  Typically you want all values to be copied.
>     Right?
> 
>     For example, if I do this:
> 
>     <match target="pattern">
>       <edit name="pangofontfeatures" mode="append">
>         <string>smcp</string>
>         <string>ss20</string>
>       </edit>
>     </match>
> 
>     only one of the strings makes it to the other side.
> 
>     Thoughts?
> 
>     --
>     behdad
>     http://behdad.org/
>     _______________________________________________
>     Fontconfig mailing list
>     Fontconfig@xxxxxxxxxxxxxxxxxxxxx <mailto:Fontconfig@xxxxxxxxxxxxxxxxxxxxx>
>     http://lists.freedesktop.org/mailman/listinfo/fontconfig
> 
> 
> 
> 
> -- 
> Akira TAGOH

-- 
behdad
http://behdad.org/
_______________________________________________
Fontconfig mailing list
Fontconfig@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/fontconfig


[Index of Archives]     [Fedora Fonts]     [Fedora Users]     [Fedora Cloud]     [Kernel]     [Fedora Packaging]     [Fedora Desktop]     [PAM]     [Gimp Graphics Editor]     [Yosemite News]

  Powered by Linux