On 13-01-08 09:31 AM, Jon TURNEY wrote: > On 31/12/2012 23:03, Behdad Esfahbod wrote: >> On 12-12-31 12:29 PM, Jon TURNEY wrote: >>> This seems to break compilation when --with-arch is used, see [1]. Attached >>> is a small patch to fix. >>> >>> [1] http://tinderbox.freedesktop.org/builds/2012-12-30-0013/logs/fontconfig/#build >> >> Thanks. Fixed. BTW, any reason that jbhuild defines FC_ARCHITECTURE >> manually? It shouldn't be needed these days. > > I guess I added it because it was needed at some time in the past. Correct. I think you can remove it. >> Also, how does the cross-compiling tinderbox bootstrap the generated header >> files that are not generated when cross compiling? > > A patch to enable cross-compilation was applied in the tinderbox. This seems > to be redundant now since you've fixed that, thanks :-) Cool. > (Although from a brief look at your patches, I'm not sure they use > EXEEXT_FOR_BUILD, which might be needed for linux->mingw cross-compilation to > work correctly) Why not? It's right in Tools.mk: TOOL=./$(DIR)$(EXEEXT_FOR_BUILD) At any rate, on Linux, the extension is irrelevant, so it would work either way. -- behdad http://behdad.org/ _______________________________________________ Fontconfig mailing list Fontconfig@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/fontconfig
