On 10/10/2012 07:16 PM, Akira TAGOH wrote:
On Thu, Oct 11, 2012 at 3:17 AM, Behdad Esfahbod <behdad@xxxxxxxxxx> wrote:
It's not my call anymore, but if it was, I would have straight rejected this
patchset. First, it mixes code and buildsystem changes. Second, it adds a
second parallel build system, that is doomed to be outdated most of the time...
Yes, that's valid point and what I was concerned earlier. that said
improving something for the native build on MSVC would be nice. though
I still prefer to improve this with autotools as far as possible or
just put minimal Makefile as other projects do.
I should pointed out more specifically, but this patch could be
separate to 1) cmake for MSVC 2) direct.h emulation at least.
Aside from how the review is going on, we have to work out on some
updates on autotools too since it's our build system and at least it
won't be shipped into the archive otherwise.
Anyway I can't promise anything so far when it will be merged because
it's the sort of big patch, I'll do my best.
I could break up this patch into 3 separate patches.
1st patch to add FcOpen, FcAccess, FcReaddir... etc macros in config-fixups.h
and replace system calls with these wrappers
2nd patch to add msvcport implementations of FcOpen, FcAccess, FcReaddir...
3rd patch to add msvcport/CMakeLists.txt
Pavel.
_______________________________________________
Fontconfig mailing list
Fontconfig@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/fontconfig
