On Fri, 13 Apr 2012, Jeremy Huddleston wrote:
On Apr 12, 2012, at 7:00 PM, Mike Frysinger <vapier@xxxxxxxxxx> wrote:
On Thursday 12 April 2012 14:22:31 Jeremy Huddleston wrote:
This caused tinderbox to fail:
http://tinderbox.x.org/builds/2012-04-03-0002/
I think expat did not start providing a .pc file until 2.1.0, which is
still in beta. Please revert the expat portion of this change.
moving to pkg-config is a great thing. i can understand if the fallback logic
of the PKG macro calls included running older xxx-config scripts, but restoring
that great glob of build crap to support older versions seems like a step
backwards.
Yeah, I agree, pkg-config rocks. It shouldn't be reverted completely. I'm just saying that if pkg-config fails for expat, we should continue to use the ugly fallback path for now rather than abort.
usually, in those cases, i do that:
1) i check the .pc file.
2) if it fails, I check header file(s) and library, with an m4 macro if
it's needed for several libraries. I wrote that one for openjpeg:
http://code.google.com/p/openjpeg/source/browse/branches/openjpeg-1.5/m4/opj_check_lib.m4
These days, I tend to reduce the number of configure options so that the
users is less lost. So for include and library search paths, I use only 2
options (a bit like ffmpeg, actually):
--extra-cppflags
--extra-ldflags
instead of plenty of --with-mylib-prefix, as, most of the time, they are
in /usr/(include,lib) anyway
regards
Vincent Torri
_______________________________________________
Fontconfig mailing list
Fontconfig@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/fontconfig
