Re: found reason for `NONE'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jan 17, 2009 at 09:00:07AM +0100, Werner LEMBERG wrote:
> 
> [I've reported this in the fontconfig bugzilla also.]
> 
> This very line in configure.in is the problem:
> 
>   fc_cachedir=`eval echo "${localstatedir}/cache/"${PACKAGE}`
> 
> In the `configure' script created with autoconf 2.63 (and probably
> other versions too), if the `--prefix' command line option is not
> given, the value of `$localstatedir' is not correctly expanded yet;
> `$prefix' is still `NONE'.  This leads to compilation commands like
> 
>   ../doltcompile gcc \
>     ... \
>     -DFC_CACHEDIR='"NONE/var/cache/fontconfig"' \
>     ...
> 
> and to 
> 
>   <cachedir>NONE/var/cache/fontconfig</cachedir>
> 
> in /usr/local/etc/fonts/fonts.conf.
> 
> Until this has been fixed in the sources, a simple workaround is to
> always call configure's `--prefix' option.

I think the patch below will take care of it. If it was substituted by
configure into, say, fontconfig.pc, it would be more trouble. But we can
just let make DTRT.

--
Dan

>From 77c83397c79e2f0c7a33493913226871028cdc37 Mon Sep 17 00:00:00 2001
From: Dan Nicholson <dbn.lists@xxxxxxxxx>
Date: Sun, 18 Jan 2009 08:43:06 -0800
Subject: [PATCH] Let make expand fc_cachedir/FC_CACHEDIR

Since configure doesn't substitute the cachedir value anywhere, we can
let make expand it, where it will be done correctly.

Signed-off-by: Dan Nicholson <dbn.lists@xxxxxxxxx>
---
 configure.in |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/configure.in b/configure.in
index e2e3f06..b0df252 100644
--- a/configure.in
+++ b/configure.in
@@ -463,7 +463,7 @@ no|yes)
 	if test "$os_win32" = "yes"; then
 		fc_cachedir="WINDOWSTEMPDIR_FONTCONFIG_CACHE"
 	else
-		fc_cachedir=`eval echo "${localstatedir}/cache/"${PACKAGE}`
+		fc_cachedir='${localstatedir}/cache/${PACKAGE}'
 	fi
 	;;
 *)
-- 
1.5.6.6
_______________________________________________
Fontconfig mailing list
Fontconfig@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/fontconfig

[Index of Archives]     [Fedora Fonts]     [Fedora Users]     [Fedora Cloud]     [Kernel]     [Fedora Packaging]     [Fedora Desktop]     [PAM]     [Gimp Graphics Editor]     [Yosemite News]

  Powered by Linux