Re: fontconfig: Branch 'master' - 9 commits

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Keith Packard wrote:
>     Typo error in function name: Inverval -> interval
>
> diff --git a/src/fccfg.c b/src/fccfg.c
> index b55770d..18a74e7 100644
> --- a/src/fccfg.c
> +++ b/src/fccfg.c
> @@ -508,7 +508,7 @@ FcConfigAddBlank (FcConfig	*config,
>  }
>  
>  int
> -FcConfigGetRescanInverval (FcConfig *config)
> +FcConfigGetRescanInterval (FcConfig *config)
>  {
>      if (!config)
>      {
> @@ -520,7 +520,7 @@ FcConfigGetRescanInverval (FcConfig *config)
>  }
>  
>  FcBool
> -FcConfigSetRescanInverval (FcConfig *config, int rescanInterval)
> +FcConfigSetRescanInterval (FcConfig *config, int rescanInterval)
>  {
>      if (!config)
>      {
This fix changes the ABI of fonconfig essentially.
May be it would be useful to smooth down the change by providing the old 
binary interface as well as the new one.
Otherwise some applications will not be able to work on systems with old 
and new fontconfig libraries simultaneously.

For example we can use gcc-specific alias attribute:

#define define_alias(name, aliasname) \
  extern __typeof(name) aliasname __attribute__((alias (#name)));

/*
 * Define FcConfigSetRescanInverval as an alias to FcConfigSetRescanInterval
 * to enable backward compatibility of fontconfig ABI.
 */
define_alias( FcConfigSetRescanInterval, FcConfigSetRescanInverval )


What do you think?

--
Alexey

_______________________________________________
Fontconfig mailing list
Fontconfig@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/fontconfig

[Index of Archives]     [Fedora Fonts]     [Fedora Users]     [Fedora Cloud]     [Kernel]     [Fedora Packaging]     [Fedora Desktop]     [PAM]     [Gimp Graphics Editor]     [Yosemite News]

  Powered by Linux