[patch] bug in FcPatternDuplicate

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi!

I noticed that Qt always uses a different font than fc-match advertises. 
Debugging the issue, I found that a call that looks pretty innocent is 
changing all weak bindings to strong bindings and as such changes the
semantic of the match: FcPatternDuplicate.

So please consider the following patch.

Greetings, Stephan

-- 
SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
diff -ru fontconfig-2.4.2/src/fcpat.c fontconfig-2.4.2.new/src/fcpat.c
--- fontconfig-2.4.2/src/fcpat.c	2006-12-02 21:54:53.000000000 +0100
+++ fontconfig-2.4.2.new/src/fcpat.c	2007-03-12 16:08:30.000000000 +0100
@@ -925,10 +925,14 @@
     for (i = 0; i < orig->num; i++)
     {
 	for (l = FcPatternEltValues(e + i); l; l = FcValueListNext(l))
-	    if (!FcPatternObjectAdd (new, e[i].object,
-				     FcValueCanonicalize(&l->value),
-				     FcTrue))
+	{
+	    if (!FcPatternObjectAddWithBinding (new, e[i].object,
+						FcValueCanonicalize(&l->value),
+						l->binding,
+						FcTrue))
 		goto bail1;
+	    
+	}
     }
 
     return new;
_______________________________________________
Fontconfig mailing list
Fontconfig@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/fontconfig

[Index of Archives]     [Fedora Fonts]     [Fedora Users]     [Fedora Cloud]     [Kernel]     [Fedora Packaging]     [Fedora Desktop]     [PAM]     [Gimp Graphics Editor]     [Yosemite News]

  Powered by Linux