On 9/9/24 2:28 PM, John Garry wrote: > On 09/09/2024 20:53, Jens Axboe wrote: >> John, >> >> Maybe it wasn't clear, but I committed that change I mentioned in my >> initial reply basically right after. > > Thanks for doing that. > >> If you could send a v2 on top of >> the current tree, that'd be great. > > I was preparing a v2 the same as this, but do you think that I should > just add a new verify option for atomic writes to ignore the header? > Or is just saying "you have selected atomic=1, so I'll just ignore the > header for you" ok? I'm still not following why atomic writes make this any different. They should not. If you have multiple writers writing the same blocks, yeah you will get verification errors. This is true for any kind of write, be it buffered, dio, or atomic. So unless I'm missing something here, I'd just drop that patch. -- Jens Axboe
