On Aug 27, 2024 / 16:08, Shin'ichiro Kawasaki wrote:
[...]
> --- a/init.c
> +++ b/init.c
> @@ -1621,12 +1621,18 @@ static int add_job(struct thread_data *td, const char *jobname, int job_add_num,
> .log_type = IO_LOG_TYPE_LAT,
> .log_offset = o->log_offset,
> .log_prio = o->log_prio,
> + .log_issue_time = o->log_issue_time,
> .log_gz = o->log_gz,
> .log_gz_store = o->log_gz_store,
> };
> const char *pre = make_log_name(o->lat_log_file, o->name);
> const char *suf;
>
> + if (o->log_issue_time && !o->log_offset) {
> + log_err("fio: log_issue_time option requires log_write_lat_log and log_offset options\n");
While I prepare v2, I found a typo here: s/log_write_lat_log/write_lat_log/
> + goto err;
> + }
> +
> if (p.log_gz_store)
> suf = "log.fz";
> else
> @@ -1650,6 +1656,9 @@ static int add_job(struct thread_data *td, const char *jobname, int job_add_num,
> setup_log(&td->clat_log, &p, logname);
> }
>
> + } else if (o->log_issue_time) {
> + log_err("fio: log_issue_time option requires log_write_lat_log and log_offset options\n");
Same here. Will fix them.
