RE: [PATCH 5/6] t/jobs: Fix a typo in jobs 23 & 24

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



 
> On 3/2/24 03:36, Avri Altman wrote:
> > s/bsrange/bssplit
> >
> > Fixes: commit c37183f8a161 (test: test job for randtrimwrite)
> > Signed-off-by: Avri Altman <avri.altman@xxxxxxx>
> > ---
> >   t/jobs/t0023.fio | 4 ++--
> >   t/jobs/t0024.fio | 2 +-
> >   2 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/t/jobs/t0023.fio b/t/jobs/t0023.fio index
> > 4f0bef89..b051fef2 100644
> > --- a/t/jobs/t0023.fio
> > +++ b/t/jobs/t0023.fio
> > @@ -33,7 +33,7 @@ bsrange=512-4k
> >   #                   block sizes match
> >   # Buggy result:     something else
> >   [bssplit]
> > -bsrange=512/25:1k:25:2k:25:4k/25
> > +bssplit=512/25:1k/:2k/:/4k
> 
> Thanks for catching this issue.
> 
> The end of the line above should be 4k/ instead of /4k
> 
> https://github.com/fiotestbot/fio/actions/runs/8121755928
Thanks.  Will fix in v2.

Thanks,
Avri

> 
> >
> >   # Expected result:  trim issued to random offset followed by write to same
> offset
> >   #                   block sizes match
> > @@ -59,5 +59,5 @@ norandommap=1
> >   #                   block sizes match
> >   # Buggy result:     something else
> >   [bssplit_no_rm]
> > -bsrange=512/25:1k:25:2k:25:4k/25
> > +bssplit=512/25:1k/:2k/:4k/
> >   norandommap=1
> > diff --git a/t/jobs/t0024.fio b/t/jobs/t0024.fio index
> > 393a2b70..2b3dc94c 100644
> > --- a/t/jobs/t0024.fio
> > +++ b/t/jobs/t0024.fio
> > @@ -33,4 +33,4 @@ bsrange=512-4k
> >   #                   block sizes match
> >   # Buggy result:     something else
> >   [bssplit]
> > -bsrange=512/25:1k:25:2k:25:4k/25
> > +bssplit=512/25:1k/:2k/:4k/





[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux