Ankit, can you take a look at this report?
Vincent
-------- Forwarded Message --------
Subject: New Defects reported by Coverity Scan for axboe/fio
Date: Thu, 25 Jan 2024 14:11:33 +0000 (UTC)
From: scan-admin@xxxxxxxxxxxx
To: vincentfu@xxxxxxxxx
Hi,
Please find the latest report on new defect(s) introduced to axboe/fio
found with Coverity Scan.
2 new defect(s) introduced to axboe/fio found with Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)
** CID 479113: Null pointer dereferences (FORWARD_NULL)
/iolog.c: 865 in setup_log()
________________________________________________________________________________________________________
*** CID 479113: Null pointer dereferences (FORWARD_NULL)
/iolog.c: 865 in setup_log()
859 }
860 861 if (l->log_offset)
862 l->log_ddir_mask = LOG_OFFSET_SAMPLE_BIT;
863 if (l->log_prio)
864 l->log_ddir_mask |= LOG_PRIO_SAMPLE_BIT;
CID 479113: Null pointer dereferences (FORWARD_NULL)
Dereferencing null pointer "l->td".
865 if (l->td->o.log_max == IO_LOG_SAMPLE_BOTH)
866 l->log_ddir_mask |= LOG_AVG_MAX_SAMPLE_BIT;
867 868 INIT_FLIST_HEAD(&l->chunk_list);
869 870 if (l->log_gz && !p->td)
** CID 479112: Null pointer dereferences (REVERSE_INULL)
/iolog.c: 870 in setup_log()
________________________________________________________________________________________________________
*** CID 479112: Null pointer dereferences (REVERSE_INULL)
/iolog.c: 870 in setup_log()
864 l->log_ddir_mask |= LOG_PRIO_SAMPLE_BIT;
865 if (l->td->o.log_max == IO_LOG_SAMPLE_BOTH)
866 l->log_ddir_mask |= LOG_AVG_MAX_SAMPLE_BIT;
867 868 INIT_FLIST_HEAD(&l->chunk_list);
869 >>> CID 479112: Null pointer dereferences (REVERSE_INULL)
Null-checking "p->td" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.
870 if (l->log_gz && !p->td)
871 l->log_gz = 0;
872 else if (l->log_gz || l->log_gz_store) {
873 mutex_init_pshared(&l->chunk_lock);
874 mutex_init_pshared(&l->deferred_free_lock);
875 p->td->flags |= TD_F_COMPRESS_LOG;
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yrQCKGyuE3tVnqEFz86FVmcUJWn9N1t5XfiQkBi4L7K62z78lv86-2B5gTPBve-2FoiHKo-3DU97O_CJKb9IrGtu4qgVSp-2FHFJxhu-2BF5b22amLmwf35hrR-2B4xqB4ty27oyqqqkWSRy-2BoQISm2b-2F6q2HYxVbKK26OMjCW-2B7XQMquvfYmi1jNArSNjeNHzxQfsnY2W6LAVOFKcXjAZ1Yn2NR34DK-2Fzuhyt-2F2hxHDRUTXFUkZCzxTluFT1veB1kVQ1hlVQQKjIkxqCu4MWUZqzAYmttshIZb5osrOWg-3D-3D
To manage Coverity Scan email notifications for
"vincentfu@xxxxxxxxx", click
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yped04pjJnmXOsUBtKYNIXxWFJgho5ClI4ODXGLipjPYnhQuq-2FmXlhvKnFaVkSqTph-2FjtSariYECqKPT6aMGOAxM8cFcHCL8DSw02AQkgwROQJhZRFIUBnJ7eYMo0qb5ys-3DJgFB_CJKb9IrGtu4qgVSp-2FHFJxhu-2BF5b22amLmwf35hrR-2B4xqB4ty27oyqqqkWSRy-2BoQI6nE0XrvIK-2BG63DOOq9XWEMEUcTxoCXAuV2EOSpu9wkNUr7HltJl2QAxB9BJ7hGsd-2B4gQJ6wtn5pSeVUhCt6Wynhkp3dxPa45HJk7LWGGTWkP6SBjDH82VmKBsQzVhLZ14AqH0rqidBRFNm94h9fU9g-3D-3D
