Re: [PATCH 1/2] stat: log out both average and max over the window

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/22/24 13:17, Jens Axboe wrote:
On 1/22/24 4:22 AM, Ankit Kumar wrote:
Modify option log_max_value to report average, max or both the values, by
setting it to 0, 1 or 2 respectively. There is no change to existing log
formats while reporting only average or max values.

That would be much cleaner as a posval instead, where it takes a textual
description rather than magic 0/1/2 values.


You could do what was done for continue_on_error, which it seems was also originally a boolean that was later expanded to have other possible values.

Maybe even change the name of this option to something like "log_lat_value" and retain the original name as an alias.

Vincent




[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux