Re: [PATCH 01/10] engines:io_uring: add missing error during open file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/9/23 07:13, Ankit Kumar wrote:
Signed-off-by: Ankit Kumar <ankit.kumar@xxxxxxxxxxx>
---
  engines/io_uring.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/engines/io_uring.c b/engines/io_uring.c
index b361e6a5..135b982d 100644
--- a/engines/io_uring.c
+++ b/engines/io_uring.c
@@ -1119,6 +1119,7 @@ static int fio_ioring_cmd_open_file(struct thread_data *td, struct fio_file *f)
  						"(LBA data size + Metadata size)\n");
  				else
  					log_err("block size must be a multiple of LBA data size\n");
+				td_verror(td, EINVAL, "fio_ioring_cmd_open_file");
  				return 1;
  			}
                  }

Please add a commit message like:

This change ensures the error is propogated to upper layers to make fio exit with a non-zero return code.



[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux