On 7/6/23 17:43, Avri Altman wrote: >> Linux kernel 6.5 will add support for IO priority hints, which can be used >> for now to specify a command duration limit for block devices supporting >> this feature. >> >> This patch series extends fio IO priority options and adds new options to >> allow users to specify IO priority hints. > Maybe while at it, remove the write_hint option that was deprecated in the > kernel a while ago. write_hint is completely unrelated to IO priority. So removing that option should be a different patch series. In any case, write_hint is indeed not supported anymore by current kernels but it can still be used with older kernels. Removing that option from fio is thus not a good idea at all as that would prevent using write_hints with older kernels and drives that support this feature. There are cases of that in the field. So nack on removing write_hint. > > Otherwise, this series looks good to me. > > Thanks, Avri > >> >> Damien Le Moal (4): os-linux: add initial support for IO priority hints >> options: add priohint option cmdprio: Add support for per I/O priority >> hint stats: Add hint information to per priority level stats >> >> HOWTO.rst | 31 +++++++++++++++++++++++++++---- backend.c >> | 9 ++++++--- cconv.c | 2 ++ engines/cmdprio.c | 9 >> ++++++--- engines/cmdprio.h | 1 + engines/io_uring.c | 25 >> +++++++++++++++++++++++-- engines/libaio.c | 21 +++++++++++++++++++++ >> fio.1 | 28 +++++++++++++++++++++++++--- options.c | >> 31 ++++++++++++++++++++++++++++--- os/os-dragonfly.h | 4 ++-- >> os/os-linux.h | 21 +++++++++++++++++---- os/os.h | 7 >> +++++-- stat.c | 10 +++++++--- thread_options.h | 3 ++- 14 >> files changed, 172 insertions(+), 30 deletions(-) >> >> -- 2.41.0 > -- Damien Le Moal Western Digital Research
