Re: [PATCH 2/7] zbd: do not reset extra zones in open conditions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 07, 2023 at 05:32:25PM +0900, Shin'ichiro Kawasaki wrote:
> The commit 954217b90191 ("zbd: Initialize open zones list referring zone
> status at fio start") introduced zone resets for zones in open condition
> which exceeds the limit of max_open_zones. However, this zone reset may
> break data in the zones even when fio does no write to them. Avoid the
> zone reset and report it as an error.
> 
> Fixes: 954217b90191 ("zbd: Initialize open zones list referring zone status at fio start")
> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@xxxxxxx>
> ---
>  zbd.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/zbd.c b/zbd.c
> index 7529e68b..832868cb 100644
> --- a/zbd.c
> +++ b/zbd.c
> @@ -1206,12 +1206,10 @@ int zbd_setup_files(struct thread_data *td)
>  				continue;
>  			/*
>  			 * If the number of open zones exceeds specified limits,
> -			 * reset all extra open zones.
> +			 * error out.
>  			 */
> -			if (zbd_reset_zone(td, f, z) < 0) {
> -				log_err("Failed to reest zone %d\n", zi);
> -				return 1;
> -			}
> +			log_err("Number of open zones exceeds max_open_zones limit\n");
> +			return 1;
>  		}
>  	}
>  
> -- 
> 2.40.1
> 

Reviewed-by: Niklas Cassel <niklas.cassel@xxxxxxx>



[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux