On 5/12/23 10:47?AM, Vincent Fu wrote: > On 5/8/23 12:01, Ankit Kumar wrote: >> - The io_uring_cmd ioengine assumes that logical block size is power of 2. >> In case of extended LBA where metadata is transferred as part of LBA >> this is not correct. Use division operation for that. The existing >> calculation for power of 2 LBA remains the same. >> >> - The current implementation doesn't support protection info and >> metadata transferred as separate buffer, return error for these >> scenarios. >> >> - Add checks to verify that block sizes are multiple of LBA size. >> - Add support for 64 LBA formats as per the latest NVM command set >> specification. >> >> Signed-off-by: Ankit Kumar <ankit.kumar@xxxxxxxxxxx> > > Ankit, overall this looks fine. > > Consider splitting this patch into two separate ones: > > 1) add support for extended LBA sizes > 2) add support for more than 16 LBA formats Exactly, that was going to be my comment too. If you need to make paragraphs on what changes are being made, that's a clear sign that they should be separate changes. -- Jens Axboe
