Re: [PATCH v3 4/8] doc: fix unit of zone_reset_threshold and relation to other option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 09, 2023 at 04:09:03PM +0900, Shin'ichiro Kawasaki wrote:
> The zone_reset_threshold option uses the 'sectors with data' accounting
> then it was described to have 'logical block' as its unit. However, the
> accounting was implemented with 'byte' unit. Fix the description of the
> option.
> 
> Also, the zone_reset_threshold option works together with the
> zone_reset_frequency option. Describe this relation also.
> 
> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@xxxxxxx>
> ---
>  HOWTO.rst | 7 ++++---
>  fio.1     | 7 ++++---
>  2 files changed, 8 insertions(+), 6 deletions(-)
> 
> diff --git a/HOWTO.rst b/HOWTO.rst
> index 17caaf5d..a5f8cc2d 100644
> --- a/HOWTO.rst
> +++ b/HOWTO.rst
> @@ -1085,9 +1085,10 @@ Target file/device
>  
>  .. option:: zone_reset_threshold=float
>  
> -	A number between zero and one that indicates the ratio of logical
> -	blocks with data to the total number of logical blocks in the test
> -	above which zones should be reset periodically.
> +	A number between zero and one that indicates the ratio of written bytes
> +	in the zones with write pointers in the IO range to the size of the IO
> +	range. When current ratio is above this ratio, zones are reset
> +	periodically as :option:`zone_reset_frequency` specifies.
>  
>  .. option:: zone_reset_frequency=float
>  
> diff --git a/fio.1 b/fio.1
> index 527b3d46..3556ad35 100644
> --- a/fio.1
> +++ b/fio.1
> @@ -854,9 +854,10 @@ of the zoned block device in use, thus allowing the option \fBmax_open_zones\fR
>  value to be larger than the device reported limit. Default: false.
>  .TP
>  .BI zone_reset_threshold \fR=\fPfloat
> -A number between zero and one that indicates the ratio of logical blocks with
> -data to the total number of logical blocks in the test above which zones
> -should be reset periodically.
> +A number between zero and one that indicates the ratio of written bytes in the
> +zones with write pointers in the IO range to the size of the IO range. When
> +current ratio is above this ratio, zones are reset periodically as
> +\fBzone_reset_frequency\fR specifies.
>  .TP
>  .BI zone_reset_frequency \fR=\fPfloat
>  A number between zero and one that indicates how often a zone reset should be
> -- 
> 2.38.1
> 

Reviewed-by: Niklas Cassel <niklas.cassel@xxxxxxx>



[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux