The following changes since commit 6d7f8d9a31f9ecdeab0eed8f23c63b9a94ec61f6:
engines/libzbc: set FIO_RO_NEEDS_RW_OPEN engine flag (2023-02-06 12:36:37 -0700)
are available in the Git repository at:
git://git.kernel.dk/fio.git master
for you to fetch changes up to f0c8ab1c36369d8d6aa214fba572dacefa3a8677:
ioengines: clarify FIO_RO_NEEDS_RW_OPEN flag (2023-02-07 10:44:00 -0500)
----------------------------------------------------------------
Vincent Fu (3):
Revert "engines/libzbc: set FIO_RO_NEEDS_RW_OPEN engine flag"
engines/libzbc: for read workloads always open devices with O_RDONLY flag
ioengines: clarify FIO_RO_NEEDS_RW_OPEN flag
engines/libzbc.c | 6 +-----
ioengines.h | 3 ++-
2 files changed, 3 insertions(+), 6 deletions(-)
---
Diff of recent changes:
diff --git a/engines/libzbc.c b/engines/libzbc.c
index dae4fe16..cb3e9ca5 100644
--- a/engines/libzbc.c
+++ b/engines/libzbc.c
@@ -68,9 +68,6 @@ static int libzbc_open_dev(struct thread_data *td, struct fio_file *f,
if (!read_only)
flags |= O_RDWR;
} else if (td_read(td)) {
- if (f->filetype == FIO_TYPE_CHAR && !read_only)
- flags |= O_RDWR;
- else
flags |= O_RDONLY;
}
@@ -469,8 +466,7 @@ FIO_STATIC struct ioengine_ops ioengine = {
.get_max_open_zones = libzbc_get_max_open_zones,
.finish_zone = libzbc_finish_zone,
.queue = libzbc_queue,
- .flags = FIO_SYNCIO | FIO_NOEXTEND | FIO_RAWIO |
- FIO_RO_NEEDS_RW_OPEN,
+ .flags = FIO_SYNCIO | FIO_NOEXTEND | FIO_RAWIO,
};
static void fio_init fio_libzbc_register(void)
diff --git a/ioengines.h b/ioengines.h
index 2cb9743e..ea799180 100644
--- a/ioengines.h
+++ b/ioengines.h
@@ -90,7 +90,8 @@ enum fio_ioengine_flags {
FIO_SKIPPABLE_IOMEM_ALLOC
= 1 << 17, /* skip iomem_alloc & iomem_free if job sets mem/iomem */
FIO_RO_NEEDS_RW_OPEN
- = 1 << 18, /* open files in rw mode even if we have a read job */
+ = 1 << 18, /* open files in rw mode even if we have a read job; only
+ affects ioengines using generic_open_file */
};
/*
