On Thu, Dec 1, 2022 at 5:11 PM Vincent Fu <vincentfu@xxxxxxxxx> wrote:
> On 11/21/22 13:28, Alberto Faria wrote:
> > When enabled, read and write requests are submitted as vectored requests
> > using blkioq_{readv,writev}(), instead of using blkioq_{read,write}().
> >
> > Signed-off-by: Alberto Faria <afaria@xxxxxxxxxx>
> > ---
> > HOWTO.rst | 4 ++++
> > engines/libblkio.c | 46 +++++++++++++++++++++++++++++++++++++++++-----
> > fio.1 | 3 +++
> > 3 files changed, 48 insertions(+), 5 deletions(-)
> >
> > diff --git a/HOWTO.rst b/HOWTO.rst
> > index cdea3258..b9c7c8df 100644
> > --- a/HOWTO.rst
> > +++ b/HOWTO.rst
> > @@ -2875,6 +2875,10 @@ with the caveat that when used on the command line, they must come after the
> > set after the engine sets any other properties, so those can be
> > overriden.
> >
> > +.. option:: libblkio_vectored=bool : [libblkio]
>
> See my response to the hipri patch regarding the difference between
> booleans and FIO_OPT_STR_SET. I don't have strong feelings regarding
> whether this should be a boolean or FIO_OPT_STR_SET but if the type
> listed in the HOWTO and manpage is boolean then the type in the options
> struct should be FIO_OPT_BOOL. No type should be listed when it's
> FIO_OPT_STR_SET.
Thanks, I went with keeping FIO_OPT_STR_SET and not listing the type
in the docs in v2.
Alberto
