Re: [PATCH 11/11] t/zbd: remove experimental_verify option from test case #54

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2022-10-21 at 15:34 +0900, Shin'ichiro Kawasaki wrote:
> The option experimental_verify does not work with zonemode=zbd. Remove
> it from the test case #54.
> 
> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@xxxxxxx>

This one looks fine, but I think that a new test case to check that --
zonemode=zbd is actually rejected when specified along with with --
experimental_verify needs to be added. With this,

Tested-by: Dmitry Fomichev <dmitry.fomichev@xxxxxxx>
Reviewed-by: Dmitry Fomichev <dmitry.fomichev@xxxxxxx>

> ---
>  t/zbd/test-zbd-support | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/t/zbd/test-zbd-support b/t/zbd/test-zbd-support
> index 0e185997..ce4a5916 100755
> --- a/t/zbd/test-zbd-support
> +++ b/t/zbd/test-zbd-support
> @@ -1178,7 +1178,6 @@ test54() {
>                 --rw=randrw:2 --rwmixwrite=25 --bsrange=4k-${zone_size} \
>                 --zonemode=zbd --zonesize=${zone_size} \
>                 --verify=crc32c --do_verify=1 --verify_backlog=2 \
> -               --experimental_verify=1 \
>                 --alloc-size=65536 --random_generator=tausworthe64 \
>                 ${job_var_opts[@]} --debug=zbd \
>                 >> "${logfile}.${test_number}" 2>&1 || return $?





[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux