On Fri, 2022-10-21 at 15:34 +0900, Shin'ichiro Kawasaki wrote:
> Current implementation checks that block size is divisor of zone size
> when verify work load is specified. After the recent fix of block size
> unaligned to zone, this check is no longer valid. Remove the check.
>
> The check had been valid since such block size left unwritten area at
> each zone end and keeps the zones in open/active status until verify
> read is done. It easily hit max open/active zones limitation. After the
> fix, the zones with unwritten area are finished then they do not hit the
> limitation.
>
> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@xxxxxxx>
Looks good.
Tested-by: Dmitry Fomichev <dmitry.fomichev@xxxxxxx>
Reviewed-by: Dmitry Fomichev <dmitry.fomichev@xxxxxxx>
> ---
> zbd.c | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/zbd.c b/zbd.c
> index 55c5c751..61856ad1 100644
> --- a/zbd.c
> +++ b/zbd.c
> @@ -649,7 +649,7 @@ static bool zbd_verify_bs(void)
> {
> struct thread_data *td;
> struct fio_file *f;
> - int i, j, k;
> + int i, j;
>
> for_each_td(td, i) {
> if (td_trim(td) &&
> @@ -671,15 +671,6 @@ static bool zbd_verify_bs(void)
> zone_size);
> return false;
> }
> - for (k = 0; k < FIO_ARRAY_SIZE(td->o.bs); k++) {
> - if (td->o.verify != VERIFY_NONE &&
> - zone_size % td->o.bs[k] != 0) {
> - log_info("%s: block size %llu is not a
> divisor of the zone size %"PRIu64"\n",
> - f->file_name, td->o.bs[k],
> - zone_size);
> - return false;
> - }
> - }
> }
> }
> return true;
