[PATCH v2 0/4] fix experimental verify

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Recently I noticed that verify workload with --experimental_verify option does
not read back verify data. I confirmed it with simple job below:

  [job]
  filename=t0025file
  size=128k
  readwrite=write
  do_verify=1
  verify=md5
  experimental_verify=1

Fio reported as follows. No read for verify data.

  Run status group 0 (all jobs):
     READ: bw=0B/s (0B/s), 0B/s-0B/s (0B/s-0B/s), io=0B (0B), run=1-1msec
     WRITE: bw=41.7MiB/s (43.7MB/s), 41.7MiB/s-41.7MiB/s (43.7MB/s-43.7MB/s)...

The debug log trace with --debug=io,verify option showed no verify data read
either. It indicates that experimental verify is not working as expected.

This series addresses two issues to make experimental verify work again. Also
add two test cases to confirm the issue fixes.

Of note is that this series makes test case #54 of t/zbd/test-zbd-support fail.
I'm preparing another series to address it as well as other verify issues
related to zonemode=zbd.

Changes from v1:
* Reflected comments on the list to patch 3 and 4

Shin'ichiro Kawasaki (4):
  verify: fix bytes_done accounting of experimental verify
  verify: fix numberio accounting of experimental verify
  test: add test for verify read back of experimental verify
  test: add test for experimental verify with loops and time_based
    options

 backend.c          |  8 ++++++--
 fio.h              |  2 ++
 io_u.c             | 23 +++++++++++++++++------
 libfio.c           |  1 +
 rate-submit.c      |  2 ++
 t/jobs/t0025.fio   |  8 ++++++++
 t/jobs/t0026.fio   | 20 ++++++++++++++++++++
 t/run-fio-tests.py | 31 +++++++++++++++++++++++++++++++
 verify.c           |  2 --
 9 files changed, 87 insertions(+), 10 deletions(-)
 create mode 100644 t/jobs/t0025.fio
 create mode 100644 t/jobs/t0026.fio

-- 
2.37.1




[Index of Archives]     [Linux Kernel]     [Linux SCSI]     [Linux IDE]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux SCSI]

  Powered by Linux