On 10/18/22 00:17, Shin'ichiro Kawasaki wrote:
Recently I noticed that verify workload with --experimental_verify option does
not read back verify data. I confirmed it with simple job below:
[job]
filename=t0025file
size=128k
readwrite=write
do_verify=1
verify=md5
experimental_verify=1
Fio reported as follows. No read for verify data.
Run status group 0 (all jobs):
READ: bw=0B/s (0B/s), 0B/s-0B/s (0B/s-0B/s), io=0B (0B), run=1-1msec
WRITE: bw=41.7MiB/s (43.7MB/s), 41.7MiB/s-41.7MiB/s (43.7MB/s-43.7MB/s)...
The debug log trace with --debug=io,verify option showed no verify data read
either. It indicates that experimental verify is not working as expected.
This series addresses two issues to make experimental verify work again. Also
add two test cases to confirm the issue fixes.
Of note is that this series makes test case #54 of t/zbd/test-zbd-support fail.
I'm preparing another series to address it as well as other verify issues
related to zonemode=zbd.
Shin'ichiro Kawasaki (4):
verify: fix bytes_done accounting of experimental verify
verify: fix numberio accounting of experimental verify
test: add test for verify read back of experimental verify
test: add test for experimental verify with loops and time_based
options
backend.c | 8 ++++++--
fio.h | 2 ++
io_u.c | 23 +++++++++++++++++------
libfio.c | 1 +
rate-submit.c | 2 ++
t/jobs/t0025.fio | 8 ++++++++
t/jobs/t0026.fio | 20 ++++++++++++++++++++
t/run-fio-tests.py | 31 +++++++++++++++++++++++++++++++
verify.c | 2 --
9 files changed, 87 insertions(+), 10 deletions(-)
create mode 100644 t/jobs/t0025.fio
create mode 100644 t/jobs/t0026.fio
Hello Shin'ichiro,
I applied your patches to a branch on GitHub:
https://github.com/vincentkfu/fio/commits/exp-verify
All of the automated Linux and macOS tests pass but on Windows I see
failures with t0026:
https://ci.appveyor.com/project/vincentkfu/fio/builds/45105941
Would you take a look?
Vincent
