Thanks for comment. I merged filecreate, filestat, filedelelete engines to fileoperations.c. The patch has been issued in another thread. -----Original Message----- From: Vincent Fu <vincentfu@xxxxxxxxx> Sent: Monday, July 18, 2022 7:24 PM To: Su, Friendy <Friendy.Su@xxxxxxxx>; fio <fio@xxxxxxxxxxxxxxx> Cc: Aoyama, Wataru (SGC) <Wataru.Aoyama@xxxxxxxx> Subject: Re: [PATCH] engines: add engine for directory create On 6/11/22 03:34, Friendy.Su@xxxxxxxx wrote: > > This engine is to measure performance of creating directories. > > Signed-off-by: friendy-su <friendy.su@xxxxxxxx> This all seems fine. My main suggestion is that there seem to be several of these file operation ioengines. It seems like we could eliminate duplicated code and make the codebase easier to maintain by consolidating the ioengines (filedelete, filestat, etc) that follow this similar structure. sync.c is an example that implements several ioengines.
